NO-JIRA: Clarify test names in OTE #1256
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@hongkailiu: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/retest-required |
hack/update-test-metadata.sh
Outdated
|
|
||
| if [[ "${DELETE_EXISTING,,}" == "true" ]] && [[ -f "${METADATA_FILE}" ]] ; then | ||
| echo "Removing ${METADATA_FILE}" | ||
| rm .openshift-tests-extension/openshift_payload_cluster-version-operator.json |
There was a problem hiding this comment.
And this file name is dynamic, it was created by
, so it's better to find a dynamic way to delete it.@DavidHurta Please correct me if I am wrong.
There was a problem hiding this comment.
I believe this discussion was resolved in the relevant Slack thread. If not, please ping me.
|
/cc |
hongkailiu
force-pushed
the
ote-guide
branch
from
e8a192b to
ae82a93
Compare
This pull add a section to clarify test names in OTE. It modifies `hack/update-test-metadata.sh` to give a hint of what to do to fix the issue.
hongkailiu
force-pushed
the
ote-guide
branch
from
ae82a93 to
626cb16
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidHurta, hongkailiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @hongkailiu |
openshift-ci-robot
added
the
verified
|
@hongkailiu: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@hongkailiu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This pull add a section to clarify test names in OTE.
It modifies
hack/update-test-metadata.shto give ahint of what to do to fix the issue.